Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a container hardening guide #35

Merged
merged 5 commits into from
Nov 17, 2021
Merged

Add a container hardening guide #35

merged 5 commits into from
Nov 17, 2021

Conversation

CSpicer-BAH
Copy link
Contributor

PR Details

Provides a detailed explanation of the container hardening process undertaken for the containers of the SDP Images repository and affiliate Iron Bank containers.

Description

Provides a detailed explanation of the container hardening process undertaken for the containers of the SDP Images repository and affiliate Iron Bank containers.

How Has This Been Tested

Types of Changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

@steven-terrana steven-terrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is good! I think it would be mergeable as a V1.

If blocking the PR pending the adjudication of my comments would help keep momentum going.. then feel free to leave the PR open.

container-hardening.md Outdated Show resolved Hide resolved
container-hardening.md Outdated Show resolved Hide resolved
container-hardening.md Outdated Show resolved Hide resolved
container-hardening.md Show resolved Hide resolved
@psig-bah
Copy link
Contributor

Incoming set of minor text/wording/consistency suggested changes, but overall looks good!
Will echo Steven's points re: images/diagrams and detailed "how-to" guides, but sounds like there are plans for both of those.

container-hardening.md Outdated Show resolved Hide resolved
container-hardening.md Outdated Show resolved Hide resolved
container-hardening.md Outdated Show resolved Hide resolved
container-hardening.md Outdated Show resolved Hide resolved
container-hardening.md Outdated Show resolved Hide resolved
container-hardening.md Outdated Show resolved Hide resolved
container-hardening.md Outdated Show resolved Hide resolved
container-hardening.md Outdated Show resolved Hide resolved
container-hardening.md Outdated Show resolved Hide resolved
container-hardening.md Outdated Show resolved Hide resolved
@psig-bah psig-bah merged commit 9bd9b0b into master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants